Skip to content

catalyst/api: centralize OPStack validation into helper functions #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: optimism
Choose a base branch
from
Open

catalyst/api: centralize OPStack validation into helper functions #592

wants to merge 8 commits into from

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Apr 28, 2025 •
edited
Loading

Closes #568

Centralizes OPStack validation for newPayload and forkchoiceUpdated into helper functions in a new file.

  • cleaner diff to upstream
  • single place to maintain these checks going forward as we add more hardforks
  • No need to duplicate in the various newPayloadV3/newPayloadV4 methods
  • adds additional validations which we were previously missing
  • unit tests added for these validations

@geoknee geoknee marked this pull request as ready for review April 28, 2025 12:02
@geoknee geoknee requested a review from a team as a code owner April 28, 2025 12:02
@geoknee geoknee requested a review from tynes April 28, 2025 12:02
@geoknee geoknee mentioned this pull request Apr 28, 2025
Closed
@geoknee geoknee requested a review from sebastianst April 28, 2025 12:04
geoknee
geoknee commented Apr 29, 2025
View reviewed changes
@sebastianst sebastianst self-assigned this Apr 29, 2025
@sebastianst sebastianst moved this to In Review in Protocol Team Apr 29, 2025
@geoknee geoknee mentioned this pull request Apr 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes Awaiting requested review from tynes tynes is a code owner automatically assigned from ethereum-optimism/op-geth-maintainers

@sebastianst sebastianst Awaiting requested review from sebastianst

At least 1 approving review is required to merge this pull request.

Assignees

@geoknee geoknee

@sebastianst sebastianst

Labels
None yet
Projects
Protocol Team
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

engine api: add checks for withdrawals list
2 participants
@geoknee @sebastianst